New Wrath Classic Binding Error for addons ?

Xrystal · 07-18-23, 07:43 AM

I last updated nUI for Wrath Classic at 3.4.1.47720 stage of wow's version. And have just now received an error when checking on a bug report from someone.

Code:

1x ...aceBlizzard_BindingUI/Blizzard_BindingUI.lua:156: attempt to index field 'key1Button' (a nil value)
[string "@Blizzard_BindingUI/Blizzard_BindingUI.lua"]:156: in function `KeyBindingFrame_LoadKeyBindingButtons'
[string "@Blizzard_BindingUI/Blizzard_BindingUI.lua"]:64: in function <...aceBlizzard_BindingUI/Blizzard_BindingUI.lua:59>
[string "=[C]"]: ?
[string "=[C]"]: in function `LoadAddOn'
[string "@nUI/Integration/nUI_KeyBinding.lua"]:45: in function <nUI/Integration/nUI_KeyBinding.lua:41>

The Error is then followed by the following xml errors

Code:

8x Blizzard_BindingUI/Blizzard_BindingUI.xml:4 Deferred XML Node object named KeyBindingFrameBindingButtonTemplate already exists

8x Blizzard_BindingUI/Blizzard_BindingUI.xml:27 Deferred XML Node object named KeyBindingFrameBindingButtonTemplateWithLabel already exists

8x Blizzard_BindingUI/Blizzard_BindingUI.xml:38 Deferred XML Node object named KeyBindingFrameBindingTemplate already exists

Now looking at nUI's line 45 all it has is this:
LoadAddOn( "Blizzard_BindingUI" )

And then proceeds to make nUI's keybinding frame that hasn't had a change since I took over outside of the backdrop changes.

But the error doesn't occur when I don't have nUI running and then open the blizzard keybindings section in the options screen. Nor when I open the blizzard keybindings section with nUI running after the error is triggered.

If I comment out the LoadAddOn line, the error goes away but .. nUI's keybinding doesn't work.

Anyone seeing this error in their addons or have an idea on what they might have changed between 3.4.1 and 3.4.2 to cause the error to appear?

Thanks in Advance

Xrystal · 07-18-23, 07:53 AM

Ah .. it appears yet again they have mixed in some dragonflight stuff again. Why not all to make it easier for us addon users.

The client has pulled in many API changes from Patch 10.1.0.

It doesn't explain this error as the KeyBinding error that I don't get on Retail wow's version

but it might explain some of the other errors that I am seeing now that I've tested one or two classic specific elements of nUI

Xrystal · 07-19-23, 07:36 PM

To make matters worse .. even the simplest of addons triggers the error .. so has anyone else had issues in this area since 3.4.1 ?

This is the simple addon I used to test on

TOC

Lua Code:

## Interface: 30401
## Title: TestKeyBindings
## Version: 3.4.1.47720.0
## DefaultState: Enabled
## LoadOnDemand: 0
 
TestKeyBindings.lua

Bindings.xml

Lua Code:

<Bindings>    
    <Binding name="TestBindingName" />
</Bindings>

Lua

Lua Code:

local frame = CreateFrame("Frame")
 
local function OnEvent(self,event,arg1,arg2)
    LoadAddOn( "Blizzard_BindingUI" );
end
 
frame:SetScript("OnEvent", OnEvent)
frame:RegisterEvent("ADDON_LOADED")

Can anyone see anything wrong with this set up ?

Thanks in advance

Xrystal · 09-29-23, 07:53 PM

I ended up removing nUI's Keybinding facility as it appears to be interfering with Blizzards system.

I also made changes to the Binding.xml file so that nUI's keybinds appear in an easy to understand system using the Category global value.