How to change pet bar hotkey color?

[atshn]

I'm using this code to change the color of hotkeys for all my bars. Works fine for everything except the pet bar. Is "PetActionButton" not the correct name or am I completely off and the code doesn't work for the pet bar at all?

for i = 1, NUM_ACTIONBAR_BUTTONS do
   local hotkey = _G["PetActionButton"..i.."HotKey"]
   hotkey:SetFont("Fonts\\FRIZQT__.ttf", 12, "THICKOUTLINE")
end

local function CustomizeHotkey(self)
   local hotkey = _G[self:GetName().."HotKey"]
   hotkey:SetTextColor(1, 1, 1, 1)
end

hooksecurefunc("ActionButton_Update", CustomizeHotkey)
hooksecurefunc("ActionButton_OnUpdate", CustomizeHotkey)

[Xrystal]

PetActionBar has it's own set of Update routines. You probably need to hook into those to apply the changes to that bar.

https://github.com/Gethe/wow-ui-sour...ionBar.lua#L93

[atshn]

Originally Posted by Xrystal PetActionBar has it's own set of Update routines. You probably need to hook into those to apply the changes to that bar. https://github.com/Gethe/wow-ui-sour...ionBar.lua#L93

I fear this one is over my head, but thank you for pointing me in the right direction.

[Xrystal]

I haven't tested these but, looking at the Blizzard Dragonflight code ( 10.2.5 ) these lines should work for the main action bar and pet action bar for retail wow.

for i=1, NUM_PET_ACTION_SLOTS, 1 do
        local button = PetActionBar.actionButtons[i]);
                hooksecurefunc(button, "SetHotKeys",function()
                    local hotkey = self.HotKey;
                     -- do your hotkey additions here
                end)
    end

for i, actionButton in pairs(ActionBar.actionButtons) do
       hooksecurefunc(actionButton,"UpdateHotKeys",function()
          local hotkey = self.HotKey;
          -- do your hotkey additions here
       end
    end

If you are working on Classic versions of wow (1.14.4 and 3.4.3) then it looks like the following could be done instead. Again, untested.

for i=1, NUM_ACTIONBAR_SLOTS, 1 do
        local button = _G["ActionButton" .. i]);
                hooksecurefunc("ActionButton_UpdateHotkeys",function(self)
                    local hotkey = self.HotKey;
                     -- do your hotkey additions here
                end)
    end

for i=1, NUM_PET_ACTION_SLOTS, 1 do
        local button = _G["PetActionButton" .. i]);
                hooksecurefunc("PetActionButton_SetHotKeys",function(self)
                    local hotkey = _G[self:GetName().."HotKey"];
                     -- do your hotkey additions here
                end)
    end

Give those a go and let us know if they work as expected for you.

[atshn]

Not working on Classic. Anything wrong with my hotkey additions?

for i=1, NUM_ACTIONBAR_SLOTS, 1 do
        local button = _G["ActionButton" .. i]);
                hooksecurefunc("ActionButton_UpdateHotkeys",function(self)
                    local hotkey = self.HotKey;
                     hotkey:SetFont("Fonts\\FRIZQT__.ttf", 12, "THICKOUTLINE")
                     hotkey:SetTextColor(1, 1, 1, 1)
                end)
    end

for i=1, NUM_PET_ACTION_SLOTS, 1 do
        local button = _G["PetActionButton" .. i]);
                hooksecurefunc("PetActionButton_SetHotKeys",function(self)
                    local hotkey = _G[self:GetName().."HotKey"];
                     hotkey:SetFont("Fonts\\FRIZQT__.ttf", 12, "THICKOUTLINE")
                     hotkey:SetTextColor(1, 1, 1, 1)
                end)
    end

[Xrystal]

Not that I can see. I'll play with it later and see if there's something else you have to do for it to work in Classic

[Xrystal]

Okay, took a while, but managed to get it working on Wrath Classic 3.4.3 using the following code

local function UpdateHotKeys(self,buttonType)
    local hotkey = self.HotKey;
    hotkey:SetFont("Fonts\\FRIZQT__.ttf", 12, "THICKOUTLINE")
    local binding = GetBindingText(GetBindingKey("ACTIONBUTTON"..self:GetID()), true);
    hotkey:SetText("|cFF00FF00" .. binding or RANGE_INDICATOR .. "|r")
    -- Green text on main action bars ( |cAARRGGBB text |r)
end
 
for i=1, NUM_ACTIONBAR_BUTTONS, 1 do
    local button = _G["ActionButton" .. i]
    hooksecurefunc("ActionButton_UpdateHotkeys",UpdateHotKeys)
    ActionButton_UpdateHotkeys(button)
end
 
 
local function SetHotKeys(self)
    local hotkey = _G[self:GetName().."HotKey"];
    hotkey:SetFont("Fonts\\FRIZQT__.ttf", 12, "THICKOUTLINE")
    local binding = GetBindingText(GetBindingKey("BONUSACTIONBUTTON"..self:GetID()), true);
    hotkey:SetText("|cFFFF0000" .. binding or RANGE_INDICATOR .. "|r")
    -- Red text on pet action bars
end
 
for i=1, NUM_PET_ACTION_SLOTS, 1 do
    local button = _G["PetActionButton" .. i]
    hooksecurefunc("PetActionButton_SetHotkeys",SetHotKeys)
    PetActionButton_SetHotkeys(button)
end

The call after the hook line triggers it straight away, otherwise it won't trigger until you change the hot key via the options. Not sure whether there will be in combat/secure issues but hopefully being done immediately on addon load rather than via event watching means it won't be a problem.

SetTextColor doesn't seem to make a difference at all regardless of where you put it in the code. But, inserting the |c and |r start and end color formatting code sequences seems to work as expected.

[atshn]

Appreciate you taking the time to do that. Me and my old eyes thank you. Didn't have much time to test it in combat but did notice that the hotkey text acting as a range indicator on both pet and action bars no longer works.

[Xrystal]

Originally Posted by atshn Appreciate you taking the time to do that. Me and my old eyes thank you. Didn't have much time to test it in combat but did notice that the hotkey text acting as a range indicator on both pet and action bars no longer works.

oh, thought I had that covered with the RANGE_INDICATOR addition if there isn't a hot key set up

You could try using this in the hotkey functions and see if that works better

if ( binding == "" ) then
   hotkey:SetText(RANGE_INDICATOR);
   hotkey:Hide();
else
   hotkey:SetText("|cFF00FF00" .. binding .. "|r")
end

or simplify it further to

if ( binding ~= "" ) then
    hotkey:SetText("|cFF00FF00" .. binding .. "|r")
end

[atshn]

Perfect. Thanks again, Xrystal!