Helm Auto-Toggle Addon - Massive help needed

darkra · 06-04-07, 05:08 AM

My knowledge of LUA is totally lacking, all i know is some stuff ive read at the WoWwiki tutorials page :S I'm 1st year programming student so i have some idea about programming, but without knowing the language....

This addon is supposed to check if the player is in combat, if yes to show helm graphic, and if not to hide it.
----.LUA file---
function HelmInCombatFrame_OnLoad()
this:RegisterEvent("PLAYER_ENTERING_WORLD");
this:SetScript("PLAYER_ENTERING_WORLD",HelmInCombat);
end

function HelmInCombat()
this:RegisterEvent("PLAYER_REGEN_DISABLED");
this:RegisterEvent("PLAYER_REGEN_ENABLED");
if(event=="PLAYER_REGEN_DISABLED") then
if(event=="PLAYER_REGEN_DISABLED") then
ShowHelm();
elseif(event=="PLAYER_REGEN_ENABLED") then
ShowHelm('false');
end
end
---
---.TOC file---
## Interface: 20100
## Title: HelmInCombat
## Notes: Enables your helm graphic when you enter combat.
## Author: DarkRa
## OptionalDeps:
## Dependencies:
HelmInCombat.lua
---
My main questions:
1) Syntax/logic. Is it correct? do i need to change something?
2) XML file. Do I need to create one? What should I put in it?

Jazradel · 06-04-07, 06:13 AM

You actually need a frame to trigger the events.
You can create a frame in the .lua. Look at http://ui.worldofwar.net/ui.php?id=3876 for a good example. Or you can create an xml file that defines the frame.

I don't think you want to register the events everytime HelmInCombat() runs, only when you load. Maybe something like this:

Code:

local HIC = CreateFrame("Frame","HIC_Frame");
HIC:RegisterEvent("PLAYER_REGEN_ENABLED");
HIC:RegisterEvent("PLAYER_REGEN_DISABLED");
HIC:SetScript("OnEvent", function() FixIncombatPetBar() end);

function HelmInCombat()
if(event=="PLAYER_REGEN_DISABLED") then
ShowHelm();
elseif(event=="PLAYER_REGEN_ENABLED") then
ShowHelm('false');
end
end

Edit: Don't trust me on this, I'm not even a first year programming student.

darkra · 06-04-07, 06:35 AM

local HIC = CreateFrame("Frame","HIC_Frame");
HIC:RegisterEvent("PLAYER_REGEN_ENABLED");
HIC:RegisterEvent("PLAYER_REGEN_DISABLED");
HIC:SetScript("OnEvent", function() HelmInCombat() end);

function HelmInCombat()
if(event=="PLAYER_REGEN_DISABLED") then
ShowHelm();
elseif(event=="PLAYER_REGEN_ENABLED") then
ShowHelm('false');
end
end

Works like a charm mate, thanks a lot

**Shirik** · 06-04-07, 03:08 PM

Originally Posted by darkra

local HIC = CreateFrame("Frame","HIC_Frame");
HIC:RegisterEvent("PLAYER_REGEN_ENABLED");
HIC:RegisterEvent("PLAYER_REGEN_DISABLED");
HIC:SetScript("OnEvent", function() HelmInCombat() end);

function HelmInCombat()
if(event=="PLAYER_REGEN_DISABLED") then
ShowHelm();
elseif(event=="PLAYER_REGEN_ENABLED") then
ShowHelm('false');
end
end

Works like a charm mate, thanks a lot

For efficiency purposes (globals are evil):

change

Code:

HIC:SetScript("OnEvent", function() HelmInCombat() end);

to

Code:

HIC:SetScript("OnEvent", HelmInCombat)

and

Code:

function HelmInCombat()

to

Code:

function HelmInCombat(self, event)

Get in the habit of doing this, otherwise you're going to see your mods start breaking when they take out the event/arg1 globals in a future patch (they are already deprecated)