RaidIndex problem

Shackleford · 08-30-12, 04:11 PM

Before the patch I used

Lua Code:

for i = 1, GetNumRaidMembers() - 1 do
--stuff
end

to exclude the player from the lookup but now with GetNumGroupMembers() - 1 this seems to include myself (the player) in the loop. Did something change in the way the Raid Indexes are assigned?

Fizzlemizz · 08-30-12, 05:13 PM

Function changed to GetNumGroupMembers()

A list of changes is at
http://www.wowpedia.org/Patch_5.0.1/API_changes

Shackleford · 08-30-12, 05:29 PM

I'm sorry maybe I wasn't clear enough in my post. Simply subbing GetNumGroupMembers() for GetNumRaidMembers() isn't my issue, its the problem of the player (myself) being indexed. Before the patch it would properly exclude the player and now it seems that GetNumGroupMembers() - 1 still includes the player. Which I'm wondering if the player isn't always the last Raid Index now.

Dridzt · 08-30-12, 05:40 PM

Can't test now but about the indexes but maybe the simplest workaround is to check with

Code:

not UnitIsUnit("player", raidunit)

and skip player that way.

Fizzlemizz · 08-30-12, 05:41 PM

It just returns a number 0 to 40. just like GetNumRaidMembers()

I would think you would need to check if one of the units in that number is you (player). In other words, it's the stuff you need to fix not the actual counter.

Shackleford · 08-30-12, 07:45 PM

Originally Posted by Dridzt

Can't test now but about the indexes but maybe the simplest workaround is to check with

Code:

not UnitIsUnit("player", raidunit)

and skip player that way.

Was able to hop into a raid tonight and check, I was indexed at 24 instead of 25. I don't know if that's how it will always return or if you get a different index every time or if its a bug, but I wasn't last. I implemented this and it seems to work fine now. Thanks.

Lombra · 08-31-12, 03:55 AM

I have no idea really, but maybe the raid leader gets the last index?

myrroddin · 08-31-12, 08:53 AM

The unit index is different between clients, and I'm not sure why. You might be raid20 on your machine, but someone else will see yet another person at raid20 on their machine, even if you are both in the same raid.

We noticed that when the raid leader was master looting. Rolling random 25, if he got himself, he would ask us, and we would say no, it is actually BobTheTank.

If I understand you correctly, you are building a table of raid members, and do not want to include yourself?

Lua Code:

local raidMembers = {}
for i = 1, GetNumGroupMembers() do
    -- we want to add everybody BUT the player
    local raider = UnitName(i)
    if not UnitIsUnit("player", raider) then
        table.insert(raidMembers, raider)
    end
end

myrroddin · 08-31-12, 09:00 AM

If you want the raidID, and not the unit's name, change line 7 to

Lua Code:

table.insert(raidMembers, raid .. i)

Phanx · 08-31-12, 07:48 PM

Originally Posted by myrroddin

The unit index is different between clients, and I'm not sure why. You might be raid20 on your machine, but someone else will see yet another person at raid20 on their machine, even if you are both in the same raid.

We noticed that when the raid leader was master looting. Rolling random 25, if he got himself, he would ask us, and we would say no, it is actually BobTheTank.

Yes, that's why the whole "/random 1-25" method of loot distribution is a scam. There's simply no way to verify which raid index someone has in another player's client. Even if the person running the scam thinks they're doing it fairly, it's still unverifiable, and thus should always be viewed as a scam and not allowed.

myrroddin · 09-01-12, 03:20 AM

Originally Posted by Phanx

Yes, that's why the whole "/random 1-25" method of loot distribution is a scam. There's simply no way to verify which raid index someone has in another player's client. Even if the person running the scam thinks they're doing it fairly, it's still unverifiable, and thus should always be viewed as a scam and not allowed.

True, and just to add to the madness: when the raid leader asked us to verify the raid member, everybody BUT him showed the same people in the same order on their machines. The weirdness only affected Master Looters and/or Raid Leaders.

In other words, "Myrroddin" was the same raid position on my machine, Jixx's, Felong's, etc, but not on Lorne's because he was the RL/ML. I can't verify the raidID was the same, however.

In any case, I'm surprised GetNumRaidMembers() -1 even worked in the first place...

Lombra · 09-01-12, 05:30 AM

Originally Posted by myrroddin

In any case, I'm surprised GetNumRaidMembers() -1 even worked in the first place...

Your own character used to always be the highest raid index, eg UnitIsUnit("player", "raid"..GetNumRaidMembers()), and I believe this no longer being the case is the reason for this thread being created.

Btw, maybe your raid leader simply used a different addon? Addons can sort the raid roster in a few different ways.

myrroddin · 09-01-12, 05:58 PM

I'd answer that Lombra, but that is getting way off the original topic. What I want to know is if Shackleford got his code fixed or not.

Phanx · 09-01-12, 07:00 PM

Originally Posted by Lombra

Addons can sort the raid roster in a few different ways.

Addons can change the order in which raid members are displayed, but they cannot change which unitID is assigned to which raid member; that's handled by the game client and/or server, and cannot be altered by addons.

Shackleford · 09-01-12, 07:47 PM

Got in another raid tonight and ran this macro as people came and gone,

Code:

/script local index = UnitInRaid("target"); if index then DEFAULT_CHAT_FRAME:AddMessage(index) end

It seems again if there were more than 20 people in the group I was indexed next to last eg. (23 out of 24 or 24 out of 25) but when there were less than 20 people I was indexed last. Checked raid leader and assistants and RL was 1 and assistants 2 and 3.

Anyways by adding the not UnitIsUnit("player", "raid"..i) check in my code it solved my problem.

myrroddin · 09-02-12, 05:52 AM

Originally Posted by Shackleford

Anyways by adding the not UnitIsUnit("player", "raid"..i) check in my code it solved my problem.

Glad to hear it!

Lombra · 09-08-12, 05:36 AM

Originally Posted by Phanx

Addons can change the order in which raid members are displayed, but they cannot change which unitID is assigned to which raid member; that's handled by the game client and/or server, and cannot be altered by addons.

Indeed. I'm assuming this raid leader just looked at their raid frames though, not checked the result of UnitName("raidN").