Slider problems

Resike · 09-17-13, 05:01 AM

Since 5.4 hit my sliders has been completely nuts. However i could fix some of the issues, but this seems a bit weird. When i set the slider with mouse clicks then the sliders ValueStep get completely ignored. Aka on a slider with 0-3 value with 1 ValueStep you can stop the slider at 0.1123123, 0.2123123, 0.3123123 etc.. values. This make the sliders function so laggy it's unbearable. However if i use the mousewheel to adjust the slider then everything works perfectly. The fun part i don't even use inherited sliders. Here is my slider and some of it's functions:

Lua Code:

<!-- Slider Template -->
    <Slider name = "PowaBarSliderTemplate" orientation = "HORIZONTAL" virtual = "true" enableMouse = "true">
        <Size>
            <AbsDimension x = "144" y = "17"/>
        </Size>
        <HitRectInsets>
            <AbsInset left = "0" right = "0" top = "-2" bottom = "1"/>
        </HitRectInsets>
        <Backdrop bgFile = "Interface\Buttons\UI-SliderBar-Background" edgeFile = "Interface\Buttons\UI-SliderBar-Border" tile = "true">
            <EdgeSize>
                <AbsValue val = "8"/>
            </EdgeSize>
            <TileSize>
                <AbsValue val = "8"/>
            </TileSize>
            <BackgroundInsets>
                <AbsInset left = "3" right = "3" top = "6" bottom = "6"/>
            </BackgroundInsets>
        </Backdrop>
        <Layers>
            <Layer level = "ARTWORK">
                <FontString name = "$parentText" inherits = "GameFontNormalSmall">
                    <Anchors>
                        <Anchor point = "BOTTOM" relativePoint = "TOP"/>
                    </Anchors>
                </FontString>
                <FontString name = "$parentLow" inherits = "GameFontHighlightSmall">
                    <Anchors>
                        <Anchor point = "TOPLEFT" relativePoint = "BOTTOMLEFT">
                            <Offset>
                                <AbsDimension x = "0" y = "-2"/>
                            </Offset>
                        </Anchor>
                    </Anchors>
                </FontString>
                <FontString name = "$parentHigh" inherits = "GameFontHighlightSmall">
                    <Anchors>
                        <Anchor point = "TOPRIGHT" relativePoint = "BOTTOMRIGHT">
                            <Offset>
                                <AbsDimension x = "0" y = "-2"/>
                            </Offset>
                        </Anchor>
                    </Anchors>
                </FontString>
            </Layer>
        </Layers>
        <Frames>
            <EditBox name = "$parentEditBox" autoFocus = "false">
                <Size>
                    <AbsDimension x = "50" y = "14"/>
                </Size>
                <Anchors>
                    <Anchor point = "TOP" relativePoint = "BOTTOM"/>
                </Anchors>
                <FontString inherits = "GameFontHighlightSmall"/>
                <Backdrop bgFile = "Interface\ChatFrame\ChatFrameBackground" edgeFile = "Interface\ChatFrame\ChatFrameBackground" tile = "true">
                    <EdgeSize>
                        <AbsValue val = "1"/>
                    </EdgeSize>
                    <TileSize>
                        <AbsValue val = "5"/>
                    </TileSize>
                </Backdrop>
                <Scripts>
                    <OnLoad>
                        self:EnableMouseWheel(true)
                        self:SetBackdropBorderColor(0.3, 0.3, 0.3, 0.8)
                        self:SetBackdropColor(0, 0, 0, 0.5)
                        self:SetJustifyH("CENTER")
                        self:SetMaxLetters(6)
                    </OnLoad>
                    <OnEnter>
                        self:SetBackdropBorderColor(0.5, 0.5, 0.5, 1)
                    </OnEnter>
                    <OnLeave>
                        self:SetBackdropBorderColor(0.3, 0.3, 0.3, 0.8)
                    </OnLeave>
                    <OnEnterPressed>
                        PowaAuras.SliderEditBoxChanged(self)
                        self:ClearFocus()
                    </OnEnterPressed>
                    <OnEditFocusLost>
                        PowaAuras.SliderEditBoxChanged(self)
                    </OnEditFocusLost>
                    <OnEscapePressed>
                        PowaAuras.SliderEditBoxChanged(self)
                        self:ClearFocus()
                    </OnEscapePressed>
                    <OnMouseWheel>
                        local slider = _G[string.sub(self:GetName(), 1, - 1 * (string.len("EditBox") + 1))]
                        PowaAuras.SliderSetValues(slider, delta)
                    </OnMouseWheel>
                </Scripts>
            </EditBox>
            <Button name = "$parentPlus">
                <Size>
                    <AbsDimension x = "18" y = "18"/>
                </Size>
                <Anchors>
                    <Anchor point = "LEFT" relativeTo = "$parentEditBox" relativePoint = "RIGHT">
                        <Offset>
                            <AbsDimension x = "0" y = "0"/>
                        </Offset>
                    </Anchor>
                </Anchors>
                <NormalTexture file = "Interface\Buttons\UI-SpellbookIcon-NextPage-Up"/>
                <PushedTexture file = "Interface\Buttons\UI-SpellbookIcon-NextPage-Down"/>
                <HighlightTexture file = "Interface\Buttons\UI-Panel-MinimizeButton-Highlight" alphaMode = "ADD"/>
                <Scripts>
                    <OnLoad>
                        self:RegisterForClicks("AnyUp")
                    </OnLoad>
                    <OnClick>
                        PowaAuras.SliderSetValues(self:GetParent(), 1)
                    </OnClick>
                </Scripts>
            </Button>
            <Button name = "$parentMinus">
                <Size>
                    <AbsDimension x = "18" y = "18"/>
                </Size>
                <Anchors>
                    <Anchor point = "RIGHT" relativeTo = "$parentEditBox" relativePoint = "LEFT">
                        <Offset>
                            <AbsDimension x = "0" y = "0"/>
                        </Offset>
                    </Anchor>
                </Anchors>
                <NormalTexture file = "Interface\Buttons\UI-SpellbookIcon-PrevPage-Up"/>
                <PushedTexture file = "Interface\Buttons\UI-SpellbookIcon-PrevPage-Down"/>
                <HighlightTexture file = "Interface\Buttons\UI-Panel-MinimizeButton-Highlight" alphaMode = "ADD"/>
                <Scripts>
                    <OnLoad>
                        self:RegisterForClicks("AnyUp")
                    </OnLoad>
                    <OnClick>
                        PowaAuras.SliderSetValues(self:GetParent(), 0)
                    </OnClick>
                </Scripts>
            </Button>
        </Frames>
        <ThumbTexture name = "$parentThumb" file = "Interface\Buttons\UI-SliderBar-Button-Horizontal">
            <Size>
                <AbsDimension x = "32" y = "32"/>
            </Size>
        </ThumbTexture>
        <Scripts>
            <OnLoad>
                self:EnableMouseWheel(true)
            </OnLoad>
            <OnEnter>
                if (self:IsEnabled()) then
                    if (self.aide) then
                        GameTooltip:SetOwner(self, "ANCHOR_RIGHT")
                        GameTooltip:SetText(self.aide, nil, nil, nil, nil, 1)
                    end
                end
            </OnEnter>
            <OnLeave>
                GameTooltip:Hide()
            </OnLeave>
            <OnMouseWheel>
                PowaAuras.SliderSetValues(self, delta)
            </OnMouseWheel>
        </Scripts>
    </Slider>
 
function PowaAuras.SliderSetValues(slider, delta)
    if (delta > 0) then
        slider:SetValue(slider:GetValue() + slider:GetValueStep())
    else
        slider:SetValue(slider:GetValue() - slider:GetValueStep())
    end
end
 
function PowaAuras.SliderOnMouseUp(self, x, y, decimals, postfix)
    local frame = self:GetName()
    local min
    local max
    if (x ~= 0) then
        min = format("%."..decimals.."f", (self:GetValue() - x))
    else
        local sliderMin = self:GetMinMaxValues()
        min = sliderMin
    end
    if (y ~= 0) then
        max = format("%."..decimals.."f", (self:GetValue() + y))
    else
        local _, sliderMax = self:GetMinMaxValues()
        max = sliderMax
    end
    self:SetMinMaxValues(min, max)
    if postfix == nil then
        _G[frame.."Low"]:SetText(min)
        _G[frame.."High"]:SetText(max)
    else
        _G[frame.."Low"]:SetText(min..postfix)
        _G[frame.."High"]:SetText(max..postfix)
    end
    PowaAuras:RedisplayAura(PowaAuras.CurrentAuraId)
end
 
function PowaAuras.SliderEditBoxSetValues(slider, editbox, x, y, decimals, endmark)
    local frame = slider:GetName()
    local slidervalue = slider:GetValue()
    local postfix = tostring(string.sub(editbox:GetText(), - 1))
    local value
    if (postfix == "%") then
        value = tonumber(string.sub(editbox:GetText(), 1, - 2))
    else
        value = tonumber(editbox:GetText())
    end
    if (value ~= nil) then
        value = format("%."..decimals.."f", value)
        local min
        local max
        if (x ~= 0) then
            min = format("%."..decimals.."f", (value - x))
        else
            local sliderMin = slider:GetMinMaxValues()
            min = sliderMin
        end
        if (y ~= 0) then
            max = format("%."..decimals.."f", (value + y))
        else
            local _, sliderMax = slider:GetMinMaxValues()
            max = sliderMax
        end
        slider:SetMinMaxValues(min, max)
        slider:SetValue(value)
        if (endmark == nil) then
            editbox:SetText(format("%."..decimals.."f", value))
        elseif (endmark == "%") then
            editbox:SetText(format("%."..decimals.."f", value)..endmark)
        else
            if (postfix == "%") then
                editbox:SetText(format("%."..decimals.."f", slider:GetValue()).."%")
            else
                editbox:SetText(format("%."..decimals.."f", slider:GetValue()))
            end
        end
        if (endmark == "%") then
            _G[frame.."Low"]:SetText(min..endmark)
            _G[frame.."High"]:SetText(max..endmark)
        else
            _G[frame.."Low"]:SetText(min)
            _G[frame.."High"]:SetText(max)
        end
    else
        if (x == 0 and y == 0) then
            local sliderMin, sliderMax = slider:GetMinMaxValues()
            slider:SetMinMaxValues(sliderMin, sliderMax)
        elseif (x == 0) then
            local sliderMin = slider:GetMinMaxValues()
            slider:SetMinMaxValues(sliderMin, slidervalue + y)
        elseif (y == 0) then
            local _, sliderMax = slider:GetMinMaxValues()
            slider:SetMinMaxValues(slidervalue - x, sliderMax)
        else
            slider:SetMinMaxValues(slidervalue - x, slidervalue + y)
        end
        slider:SetValue(slidervalue)
        if (endmark == "%") then
            editbox:SetText(format("%."..decimals.."f", slidervalue)..endmark)
        else
            editbox:SetText(format("%."..decimals.."f", slidervalue))
        end
        if (endmark == "%") then
            _G[frame.."Low"]:SetText((slidervalue - x)..endmark)
            _G[frame.."High"]:SetText((slidervalue + y)..endmark)
        else
            _G[frame.."Low"]:SetText(slidervalue - x)
            _G[frame.."High"]:SetText(slidervalue + y)
        end
    end
    PowaAuras:RedisplayAura(PowaAuras.CurrentAuraId)
end
 
function PowaAuras.SliderEditBoxChanged(self)
    local frame = self:GetName()
    local slider = _G[string.sub(frame, 1, - 1 * (string.len("EditBox") + 1))]
    local postfix = tostring(string.sub(self:GetText(), - 1))
    if (slider == PowaBarAuraSizeSlider) then
        PowaAuras.SliderEditBoxSetValues(slider, self, 0, 100, 0, "%")
    elseif (slider == PowaBarAuraCoordXSlider or slider == PowaTimerCoordXSlider or slider == PowaStacksCoordXSlider) then
        PowaAuras.SliderEditBoxSetValues(slider, self, 700, 700, 0)
    elseif (slider == PowaBarAuraCoordYSlider or slider == PowaTimerCoordYSlider or slider == PowaStacksCoordYSlider) then
        PowaAuras.SliderEditBoxSetValues(slider, self, 400, 400, 0)
    elseif (slider == PowaModelPositionZSlider) then
        PowaAuras.SliderEditBoxSetValues(slider, self, 100, 100, 0)
    elseif (slider == PowaModelPositionXSlider or slider == PowaModelPositionYSlider) then
        PowaAuras.SliderEditBoxSetValues(slider, self, 50, 50, 0)
    end
    if ((postfix == "%") and (slider == PowaBarAuraAlphaSlider or slider == PowaTimerSizeSlider or slider == PowaTimerAlphaSlider or slider == PowaStacksSizeSlider or slider == PowaStacksAlphaSlider)) then
        local text = tonumber(string.sub(self:GetText(), 1, - 2))
        if (text ~= nil) then
            text = text / 100
            slider:SetValue(text)
            self:SetText(format("%.0f", (slider:GetValue() * 100)).."%")
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (text <= sliderlow or text >= sliderhigh) then
                self:SetText(format("%.0f", (slider:GetValue() * 100)).."%")
            end
        else
            self:SetText(format("%.0f", (slider:GetValue() * 100)).."%")
        end
    elseif (postfix == "%" and (slider == PowaBarAuraSizeSlider or slider == PowaBarAuraAnimSpeedSlider)) then
        local text = tonumber(string.sub(self:GetText(), 1, - 2))
        if (text ~= nil) then
            slider:SetValue(text)
            self:SetText(format("%.0f", (slider:GetValue())).."%")
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (text <= sliderlow or text >= sliderhigh) then
                self:SetText(format("%.0f", slider:GetValue()).."%")
            end
        else
            self:SetText(format("%.0f", slider:GetValue()).."%")
        end
    elseif (postfix == "%" and (slider == PowaBarThresholdSlider)) then
        local text = tonumber(string.sub(self:GetText(), 1, - 2))
        local aura = PowaAuras.Auras[PowaAuras.CurrentAuraId]
        if (text ~= nil and aura.RangeType == "%") then
            slider:SetValue(text)
            self:SetText(format("%.0f", (slider:GetValue()))..aura.RangeType)
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (text <= sliderlow or text >= sliderhigh) then
                self:SetText(format("%.0f", slider:GetValue())..aura.RangeType)
            end
        else
            self:SetText(format("%.0f", slider:GetValue())..aura.RangeType)
        end
    elseif (slider == PowaBarAuraAlphaSlider or slider == PowaTimerSizeSlider or slider == PowaTimerAlphaSlider or slider == PowaStacksSizeSlider or slider == PowaStacksAlphaSlider) then
        local text = tonumber(self:GetText())
        if (text ~= nil) then
            text = text / 100
            slider:SetValue(text)
            self:SetText(format("%.0f", (slider:GetValue() * 100)).."%")
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (text < sliderlow or text > sliderhigh) then
                self:SetText(format("%.0f", (slider:GetValue() * 100)).."%")
            end
        else
            self:SetText(format("%.0f", (slider:GetValue() * 100)).."%")
        end
    elseif (slider == PowaBarAuraSizeSlider or slider == PowaBarAuraAnimSpeedSlider) then
        local text = tonumber(self:GetText())
        if (text ~= nil) then
            slider:SetValue(text)
            self:SetText(format("%.0f", (slider:GetValue())).."%")
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (text <= sliderlow or text >= sliderhigh) then
                self:SetText(format("%.0f", slider:GetValue()).."%")
            end
        else
            self:SetText(format("%.0f", slider:GetValue()).."%")
        end
    elseif (slider == PowaBarThresholdSlider) then
        local text = tonumber(self:GetText())
        local aura = PowaAuras.Auras[PowaAuras.CurrentAuraId]
        if (text ~= nil) then
            slider:SetValue(text)
            self:SetText(format("%.0f", (slider:GetValue()))..aura.RangeType)
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (text <= sliderlow or text >= sliderhigh) then
                self:SetText(format("%.0f", slider:GetValue())..aura.RangeType)
            end
        else
            self:SetText(format("%.0f", slider:GetValue())..aura.RangeType)
        end
    elseif (tonumber(postfix) == nil and slider == PowaBarAuraRotateSlider) then
        local text = tonumber(string.sub(self:GetText(), 1, - 2))
        if text == nil then
            text = tonumber(string.sub(self:GetText(), 1, - 3))
        end
        if (text ~= nil) then
            slider:SetValue(text)
            self:SetText(format("%.0f", slider:GetValue()).."°")
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (text < sliderlow or text > sliderhigh) then
                self:SetText(format("%.0f", slider:GetValue()).."°")
            end
        else
            self:SetText(format("%.0f", slider:GetValue()).."°")
        end
    elseif (slider == PowaBarAuraRotateSlider) then
        local text = tonumber(self:GetText())
        if (text ~= nil) then
            slider:SetValue(text)
            self:SetText(format("%.0f", slider:GetValue()).."°")
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (text < sliderlow or text > sliderhigh) then
                self:SetText(format("%.0f", slider:GetValue()).."°")
            end
        else
            self:SetText(format("%.0f", slider:GetValue()).."°")
        end
    elseif (slider == PowaBarAuraDeformSlider or slider == PowaBarAuraDurationSlider or slider == PowaTimerDurationSlider or slider == PowaTimerInvertAuraSlider) then
        if (tonumber(self:GetText()) ~= nil) then
            slider:SetValue(tonumber(self:GetText()))
            self:SetText(format("%.2f", slider:GetValue()))
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (tonumber(self:GetText()) < sliderlow or tonumber(self:GetText()) > sliderhigh) then
                self:SetText(slider:GetValue())
            end
        else
            self:SetText(slider:GetValue())
        end
    else
        if (tonumber(self:GetText()) ~= nil) then
            slider:SetValue(tonumber(self:GetText()))
            self:SetText(format("%.0f", slider:GetValue()))
            local sliderlow, sliderhigh = slider:GetMinMaxValues()
            if (tonumber(self:GetText()) < sliderlow) or (tonumber(self:GetText()) > sliderhigh) then
                self:SetText(slider:GetValue())
            end
        else
            self:SetText(slider:GetValue())
        end
    end
end

I'm aware of i could easily fix this with a "format("%.0f", SliderValue)" but this would not make the lagg go away since it would still use long float numbers.

The real problem pretty much anything made/changed since the start of 5.4 going to have corrupted values and not gonna work properly.

zork · 09-17-13, 05:33 AM

Hmmm....I do this:

Lua Code:

--simple round number func
  local SimpleRound = function(val,valStep)
    return floor(val/valStep)*valStep
  end
 
  --basic slider func
  local CreateBasicSlider = function(parent, name, title, minVal, maxVal, valStep)
    local slider = CreateFrame("Slider", name, parent, "OptionsSliderTemplate")
    local editbox = CreateFrame("EditBox", "$parentEditBox", slider, "InputBoxTemplate")
    slider:SetMinMaxValues(minVal, maxVal)
    --slider:SetValue(0)
    slider:SetValueStep(valStep)
    slider.text = _G[name.."Text"]
    slider.text:SetText(title)
    slider.textLow = _G[name.."Low"]
    slider.textHigh = _G[name.."High"]
    slider.textLow:SetText(floor(minVal))
    slider.textHigh:SetText(floor(maxVal))
    slider.textLow:SetTextColor(0.4,0.4,0.4)
    slider.textHigh:SetTextColor(0.4,0.4,0.4)
    editbox:SetSize(50,30)
    editbox:ClearAllPoints()
    editbox:SetPoint("LEFT", slider, "RIGHT", 15, 0)
    editbox:SetText(slider:GetValue())
    editbox:SetAutoFocus(false)
    slider:SetScript("OnValueChanged", function(self,value)
      self.editbox:SetText(SimpleRound (value,valStep))
    end)
    editbox:SetScript("OnTextChanged", function(self)
      local val = self:GetText()
      if tonumber(val) then
         self:GetParent():SetValue(val)
      end
    end)
    editbox:SetScript("OnEnterPressed", function(self)
      local val = self:GetText()
      if tonumber(val) then
         self:GetParent():SetValue(val)
         self:ClearFocus()
      end
    end)
    slider.editbox = editbox
    return slider
  end
 
  --create slider
    local slider = CreateBasicSlider(parent, "MySliderName", "Alpha", 0, 1, 0.001)
    slider:HookScript("OnValueChanged", function(self,value)
      --save value
    end)

Resike · 09-17-13, 05:48 AM

Yeah i found some workarounds too, but the main problem how the heck am i gonna fix the already saved existing problems, aka when someone set their holy power to 1.1231241231 instead of 1?

humfras · 09-17-13, 07:26 AM

Originally Posted by Resike

Yeah i found some workarounds too, but the main problem how the heck am i gonna fix the already saved existing problems, aka when someone set their holy power to 1.1231241231 instead of 1?

There is no other more efficient way to string.format or floor(value/step)*step.
The lag must be caused by something else.
I once encountered this myself when using a simple self made slider. The problem mysteriously didn't occur when using the Ace3 one...

**Seerah** · 09-17-13, 09:41 AM

Ace3 was updated for this change in the API with 5.4.

Haleth · 09-17-13, 02:49 PM

This happens with every form of slider in 5.4, it's also noticeable in scroll frames when you try dragging the 'grip' rather than scrolling with the mouse.

Resike · 09-17-13, 02:57 PM

Originally Posted by humfras

There is no other more efficient way to string.format or floor(value/step)*step.
The lag must be caused by something else.
I once encountered this myself when using a simple self made slider. The problem mysteriously didn't occur when using the Ace3 one...

Of course this causing the lag, have you ever tried to calculate with 30 character long float values multiple times under a second? Specially when you use it on slider which is handling high resolution textures/ingame models, like alpha, rotation, zoom, width, height, position changes.

Phanx · 09-17-13, 10:57 PM

Originally Posted by Resike

Specially when you use it on slider which is handling high resolution textures/ingame models, like alpha, rotation, zoom, width, height, position changes.

If you're using a slider to change something that's going to hang the client if you change it 1000 times per second, you should use some kind of throttling to make sure you don't change it 1000 times per second while the user is dragging the slider, or wait until the user lets go of the slider to apply the change.

Resike · 09-18-13, 06:29 AM

Originally Posted by Phanx

If you're using a slider to change something that's going to hang the client if you change it 1000 times per second, you should use some kind of throttling to make sure you don't change it 1000 times per second while the user is dragging the slider, or wait until the user lets go of the slider to apply the change.

I already have that built in. But since the slider bug updates the slider value on every pixel it's not really working.

Phanx · 09-18-13, 03:52 PM

I'm not sure what you mean... slider widgets have always run OnValueChanged scripts 498302483242 times a second while the user is dragging the slider. To ignore changes during dragging, and only update when the slider is released, you'd use OnMouseUp instead of OnValueChanged, or check IsMouseButtonDown in your OnValueChanged script and either ignore changes made with a mouse button down, or only pass values to the addon while the mouse button is down if the last value was passed more than X time ago. The only thing that's changed in 5.4 is that the values passed to OnValueChanged scripts while the slider is being dragged no longer respect the slider's step value. Nothing else has changed.

Resike · 09-18-13, 04:40 PM

Originally Posted by Phanx

I'm not sure what you mean... slider widgets have always run OnValueChanged scripts 498302483242 times a second while the user is dragging the slider. To ignore changes during dragging, and only update when the slider is released, you'd use OnMouseUp instead of OnValueChanged, or check IsMouseButtonDown in your OnValueChanged script and either ignore changes made with a mouse button down, or only pass values to the addon while the mouse button is down if the last value was passed more than X time ago. The only thing that's changed in 5.4 is that the values passed to OnValueChanged scripts while the slider is being dragged no longer respect the slider's step value. Nothing else has changed.

Well my method woks like that on every OnValueChanged i do something like this:

Lua Code:

local SliderValue = Slider:GetValue()
if (SliderValue ~= SavedVariable) then
    -- Change it's value
end

This also stop the pointless cpu usage when you hold the mouse button down on the slider but not moving it. And it's working pretty well with a well set ValueStep, even when i go nuts on sliders it's wont use more then 0.5-1% cpu time. (But depends on which function is the slider handling.)

Phanx · 09-18-13, 05:36 PM

1) If you're running that code inside an OnValueChanged script, you should just use the value passed to the script itself, instead of calling GetValue again to get the same value.

2) A simple workaround for your case would be to manually round the new value according to your slider's step value before checking it against your saved value.

Code:

slider:SetStepValue(5)
slider.stepValue = 5 -- store it here for faster access later

slider:SetScript("OnValueChanged", function(slider, value)
   local halfStep = slider.stepValue / 2
   value = value + halfStep - (value + halfStep) % slider.stepValue -- faster than calling math.floor
   if value ~= SAVED_VALUE then
      -- Do stuff
   end
end)

Resike · 09-19-13, 04:30 AM

Originally Posted by Phanx

1) If you're running that code inside an OnValueChanged script, you should just use the value passed to the script itself, instead of calling GetValue again to get the same value.

2) A simple workaround for your case would be to manually round the new value according to your slider's step value before checking it against your saved value.

Code:

slider:SetStepValue(5)
slider.stepValue = 5 -- store it here for faster access later

slider:SetScript("OnValueChanged", function(slider, value)
   local halfStep = slider.stepValue / 2
   value = value + halfStep - (value + halfStep) % slider.stepValue -- faster than calling math.floor
   if value ~= SAVED_VALUE then
      -- Do stuff
   end
end)

I already tried that but it doesn't solve the problem triggers, the real problem is the script getting triggered by 6 million times and even a floor function like this makes the slider laggy.

We need a solution like that which doesn't trigger the script itself when it's unnessecary.

zork · 09-19-13, 06:02 AM

Try to disable the click function and check for the result.
If it does any good just replace the OnClick event function with your own.

Lua Code:

slider:SetScript("OnClick", function(self,...)
  print(...)
end)

Resike · 09-19-13, 06:07 AM

Originally Posted by zork

Try to disable the click function and check for the result.
If it does any good just replace the OnClick event function with your own.

Lua Code:

slider:SetScript("OnClick", function(self,...)
  print(...)
end)

That would work i guess, but then the slider wouldn't get updated when you move the mouse on it. And i would like to keep that function if it's possible.

However i saw a possible solution here:

http://www.wowwiki.com/Patch_5.4.0/API_changes

I might try this one.

Resike · 09-19-13, 01:29 PM

Even with this method the lagg is still there.

Phanx · 09-19-13, 04:34 PM

1) There was no floor function call in the code I posted.

2) Without seeing your entire, actual code, there is no way I or anyone else can really tell you why your slider is so laggy. All we can do is offer blind guesses.

Resike · 09-20-13, 02:21 AM

Originally Posted by Phanx

1) There was no floor function call in the code I posted.

2) Without seeing your entire, actual code, there is no way I or anyone else can really tell you why your slider is so laggy. All we can do is offer blind guesses.

1) But the calculations there works pretty much just as the floor.

2) I know why is it laggy, the problem i don't know how to fix it properly.

I posted most of the slider code in my first comment, but here is the full:

https://github.com/Resike/PowerAuras

Lombra · 09-20-13, 10:42 AM

Not sure if this adds anything to the discussion, but I have a scroll frame inheriting the hybrid scroll frame template. I don't do anything to throttle the running of the update function, and I have not changed anything since the patch. It is definitely noticably more laggy. (not that it was laggy at all before) I'm fairly sure I've noticed it in the default UI's scroll frames as well.

Edit: Yep, simple things like the character stats frame and the quest log lag. Scrolling does not seem to affect the rest of the game, though.

zork · 09-23-13, 04:34 AM

Maybe http://wowpedia.org/API_Slider_SetStepsPerPage, http://wowpedia.org/API_Slider_GetStepsPerPage causes a sort of endless loop? That are the only changes since 5.4 for slider object.

Getting an endless loop is easy. You set a value and on value set you call a function that sets a value. O_O

What will this do for you?

Lua Code:

--If steps >= 1, the Slider's value will be changed by 
--exactly Slider:GetValueStep()*math.floor(steps) in the 
--direction of the click.
slider:SetStepsPerPage(0) --disable SetStepsPerPage
 
--[[
slider.SetStepsPerPage = function(...) 
  print(self:GetName().." called SetStepsPerPage")
  print(...)
end
 
slider.GetStepsPerPage = function(...) 
  print(self:GetName().." called GetStepsPerPage")
  print(...)
end
]]--

If your valuestep is very low (0.001 or lower) make sure to use bigger steps like: 1/valueStep