Small bug in my nameplate addon, the castbar, wtb help of lua genius please.

[Falleneu]

Hey, I have been using a heavily edited version of SH_Nameplates, a addon that hasn't been updated for 2+years now and I kept alive through my poor lua skills. Half a year ago the addon's castbar randomly broke and I came here for some help and a kind member called "Oppugno" fixed it for me.

Sadly the addon on PTR/BETA is broken again in the same section, the name of the spell and the spell duration no longer shows, also if a mob is casting, and WHILE it is casting I target said mob, the castbar decides to grow in hight X10.

http://www.wowinterface.com/forums/s...ad.php?t=48963 Thats the old post.


I hope perhaps someone can help me out here once again.

Thanks anyone for reading this and possibly helping me.

/Nuckels

[Phanx]

I haven't looked at the code, but whatever the problem is is certainly fixable... however, at this point, you would probably be better off just switching to any of the many nameplate addons that are still actively maintained by their authors. Searching for "plate" should find them all.

[Tonyleila]

KuiNameplates

[Phanx]

Yeah, that's what I use as well, but there are others to choose from if you prefer another style.

[Falleneu]

Originally Posted by Phanx I haven't looked at the code, but whatever the problem is is certainly fixable... however, at this point, you would probably be better off just switching to any of the many nameplate addons that are still actively maintained by their authors. Searching for "plate" should find them all.

I know but I just really like these and I hate swapping nameplate addon as a tank, so I am really hoping on fixing these.

Edit: disabling " if self:IsShown() ~= 1 then return end " makes them work again, what does that line exactly do? It returned a 1 on beta so I just decided to disable it but ya.

Edit 2: perhaps it helps if i link all the code, so ya here that line is alreayd disabled that part with --

----------------------------
--- EVENT HANDLERS/CUSTOM---
----------------------------
local function OnSizeChanged(self, width, height)
    if self:IsShown() ~= 1 then return end
        
    if height > cfg.castbar.height then
        self.needFix = true
    end
end
 
local function OnValueChanged(self, curValue)
     -- if self:IsShown() ~= 1 then return end
    UpdateTime(self, curValue) 
    
    --fix castbar from bloating - as a back up to onshow fixcastbar call
    if self:GetHeight() > cfg.castbar.height or self.needFix then
        FixCastbar(self)
        self.needFix = nil
    end
    
    -- --another safety to ensure proper casbar coloring for interruptable vs uninteruptable items
    -- if self.controller and select(2, self:GetStatusBarColor()) > 0.15 then 
        -- self:SetStatusBarColor(0.83, 0.14, 0.14) 
    -- end
end
 
local function OnShow(self)
    FixCastbar(self)
    self.IconOverlay:Show()
    ColorCastbar(self, self.shieldedRegion:IsShown() == 1) 
end
 
local function OnHide(self)
    self.highlight:Hide()
end

[semlar]

Never compare something like IsShown() to an explicit value like 1 or true, you should pretty much always just do "if not f:IsShown() then" to check that it's not being shown.

I don't think OnSizeChanged can even fire for a hidden frame, anyway.

Just remove the line, it doesn't do anything. It's breaking the function because IsShown() can never return 1 (it returns true on the beta).

This is not the only place you're comparing IsShown() to 1, so you'll have to clean up a few other areas.

[Falleneu]

Originally Posted by semlar Never compare something like IsShown() to an explicit value like 1 or true, you should pretty much always just do "if not f:IsShown() then" to check that it's not being shown. I don't think OnSizeChanged can even fire for a hidden frame, anyway. Just remove the line, it doesn't do anything. It's breaking the function because IsShown() can never return 1 (it returns true on the beta). This is not the only place you're comparing IsShown() to 1, so you'll have to clean up a few other areas.

I wish I was better at this, surprising that it even works on Live without issues the way I read this.

[Choonstertwo]

Originally Posted by Falleneu I wish I was better at this, surprising that it even works on Live without issues the way I read this.

On live a lot of functions return 1/nil for "boolean" values, but WoD changes most (if not all) of them to return the actual boolean values true/false instead. Explicitly comparing to 1 works if the function returns 1/nil, but it's best to treat them as booleans so you don't need to worry about the specific values returned as long as they evaluate to true/false in boolean expressions (nil and false evaluate to false, everything else to true).

I'm not sure why Blizzard was using 1/nil in the first place, since even Lua 5.0 (the version of Lua initially used by the game) had proper booleans.