(11Kb)

Compatible with Retail, Classic & TBC

Updated: 09-08-24 04:35 AM

Add Favorite

Install Help

Portal

Bugs

Features

Pictures

File Info

Compatibility:	The War Within (11.0.2) Cataclysm Classic (4.4.0) Classic (1.15.2)
Updated:	09-08-24 04:35 AM
Created:	07-24-12 08:03 AM
Downloads:	13,320
Favorites:	72
MD5:

11.0.2

Battle Pet Tabs

Version: v11.0.2.240908

by: Vladinator [More]

Official repository can be found at GitHub.

You can create up to 10 team loadouts and toggle between them by pressing the tabs on the Pet Journal - could it get any simpler? You can also store your team compositions into a dropbox, and then easily swap between active and inactive teams!

BattlePetTabs
v11.0.2.240908 (2024-09-08)
Full Changelog Previous Releases

TOC bump.
Merge branch 'master' of https://github.com/Vladinator/wow-addon-battlepettabs
TOC bump and patch 11 update.
Update release.yml
Update release.yml to use actions/checkout@v4
Preparation for 11.0
Added title suffix to explain its a placeholder.
Added TOC files for the other clients.
TOC bump for 10.1
Updated for 10.0.0
TOC bump
DF support
TOC bump
Fixed taint issue source, this should minimize the issue people have been having.
Added pet exist checks, as sometimes the data could be loaded in a separate account or the pet gets caged and becomes missing.
Correct TOC bump for SL pre-patch.
Cleaned up deprecated file.
Create release.yml
TOC bump seems to work fine in Shadowlands.
TOC bump
Just to be super safe, ignore the travis file by name.
TOC bump and WoWInterface automatic packaging.
Added a mouseover check if the frame is forbidden. An error was introduced with the latest patch if I don't check for this when hover over different things, and your mouse lands on a nameplate for example it would error.
Removed obsolete code that did more harm than good.
Version bump.
- Shows equipped pet team border if you move the team to inactive, but still click teams from the popup to equip or adjust said inactive team.
- Moving inactive teams now doesn't swap two teams position, instead you drag a team in front another team, this makes moving teams in the inactive panel a bit easier if you just want to slot a new team between some other teams.
Fixed bugs introduced in 8.2
- Added a confirmation when deleting a team. Not sure why I didn't do this much earlier.
- Made it possible to load teams that are stored in the bank in case you quickly want to load one that is less used for some specific purpose.
Updated for BfA.
Patch 7.2 update.
Updated the readme file.
Cleaned up TOC
Initial Legion commit. Recoded the entire addon. Has backwards compatibility for Warlords of Draenor, despite it appearing as "Out of date"
Fixed an issue where the addon loading happened before the addon finished actually loading the code from its file #weird
WOD beta release code.
Disable integrity checking of teams, as this seem to do more damage than good. Also changed some validation logic of pet ID to work with the changes in WoD.
License change. Get in touch with me if you wish to discuss.
Removed deprecated code and reorganized some references. Tweaked how petID related functions work, now that WOD changed the GUID entirely - again.
Initial addon commit.
Initial commit

Optional Files (0)

Archived Files (4)

File Name	Version	Size	Author	Date
Battle Pet Tabs	v11.0.0.240730	11kB	Vladinator	07-30-24 04:00 AM
Battle Pet Tabs	v10.1.0.230503	9kB	Vladinator	05-04-23 04:01 AM
Battle Pet Tabs	v10.0.0.221026	9kB	Vladinator	10-26-22 02:11 PM
Battle Pet Tabs	v9.2.7.220917	9kB	Vladinator	09-17-22 09:11 AM

Comment Options

Page 1 of 2

07-25-12, 01:21 PM

nullberri

A Kobold Labourer

Forum posts: 0

File comments: 2

Uploads: 3

Fresh install with no previous saved variables file and i get an error when i click the first tab.

searching thru your code it looks like you never initialize BattlePetTabsDB to some default value if BattlePetTabsDB is nil.

Workaround is to /run BattlePetTabsDB = {} then click a button, you'll get an error but after that it works fine.

Code:

Message: Interface\AddOns\BattlePetTabs\core.lua:285: attempt to index global 'BattlePetTabsDB' (a nil value)
Time: 07/25/12 12:19:30
Count: 1
Stack: Interface\AddOns\BattlePetTabs\core.lua:285: in function `BattlePetTab_OnClick'
[string "*:OnClick"]:1: in function <[string "*:OnClick"]:1>

Locals: self = BattlePetTabsTab1Button {
 0 = <userdata>
 searchOverlay = BattlePetTabsTab1ButtonSearchOverlay {
 }
}
button = "RightButton"
currentId = 1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index global 'BattlePetTabsDB' (a nil value)"

Last edited by nullberri : 07-25-12 at 01:26 PM.

07-25-12, 01:28 PM
nullberri A Kobold Labourer Forum posts: 0 File comments: 2 Uploads: 3	Bugs: Rapidly switching teams does not reliably switch teams; Abilities are not saved / restored when switching teams (when switching teams succeeds) When a pet is caged/released from a team that is not the current team, switching to that team throws an error. calls to C_PetJournal.SetPetLoadOutInfo and C_PetJournal.SetAbility are throttled internally and need to be set, and rechecked during an onupdate to ensure they get set properly. Last edited by nullberri : 07-25-12 at 01:34 PM.

07-26-12, 11:22 AM

Vlad

A Molten Giant

Forum posts: 793

File comments: 337

Uploads: 31

*Edit*

1.0.6 is pending review, it fixed the team swapping issue where pets would revert their abilities back to default instead of using what was assigned to them by the player. For example if you have a Beast that knows Scratch and you set it to use Thrash, after swapping teams it will properly set it's ability back to Thrash instead of reverting to default and use Scratch.

Originally Posted by nullberri

<snip>

Thanks for the reports, this is what I have changed and fixed for next release:

- Variable initialization shouldn't error, tested it several times on an empty client. Still if it occurs do tell me.
- Quickly toggling teams will result into sloppy updating, since the game isn't designed to change all the pets at once, so to counter this there is an internal updater checking each 250ms and corrects the loadout if it's not properly loaded. In short, team swapping should always perform as expected.
- If you cage a pet from a team, that pet is no longer a member of that team and will not error. If you cage all the pets from a team, that team will be removed. (Note that you can generate an error if you cage a pet and swap team before the game can fire the pet journal update event, this causes the addon to assume you still got the pet and try to load it while in reality you don't. This shouldn't be a problem as long people don't deliberately quickly cage and swap to a team with the caged pet, I'll anyway try completely fix this for some future build.)

I have uploaded the changes and you can try them out shortly. Keep me informed of bugs, thanks.

Last edited by Vlad : 07-26-12 at 02:17 PM.

07-26-12, 04:45 PM
Twilit Soul A Defias Bandit Forum posts: 2 File comments: 8 Uploads: 0	Thanks! I love this addon! I can see it becoming hugely popular by release day. Much appreciated =)

07-27-12, 08:32 AM

Vlad

A Molten Giant

Forum posts: 793

File comments: 337

Uploads: 31

Re: Thanks!

Originally Posted by Twilit Soul

I love this addon!

I am glad you find it to your liking.

The only thing that can be discussed is the number of teams one can create. I think 8 is enough for most, but I am open for suggestions of any sort, not just the maximum number of teams.

07-29-12, 06:19 PM

A_Nolan

A Deviate Faerie Dragon

Forum posts: 16

File comments: 56

Uploads: 9

error opening pet window

error i found i have the 7/28/12 version 1.0.7
activated when i opened the pet window

Date: 2012-07-29 19:12:43
ID: 1
Error occured in: Global
Count: 1
Message: ..\AddOns\BattlePetTabs\core.lua line 331:
attempt to index field '?' (a nil value)
Debug:
[C]: ?
BattlePetTabs\core.lua:331: BattlePetTab_LoadTeamId()
BattlePetTabs\core.lua:222: BattlePetTabs_OnEvent()
[string "*:OnEvent"]:1:
[string "*:OnEvent"]:1
[C]: LoadAddOn()
..\FrameXML\UIParent.lua:299: UIParentLoadAddOn()
..\FrameXML\UIParent.lua:432: PetJournal_LoadUI()
..\FrameXML\UIParent.lua:633: TogglePetJournal()
[string "*:OnClick"]:1:
[string "*:OnClick"]:1
AddOns:
Swatter, v5.13.5258 (BoldBandicoot)
Bagnon, v4.3.0
BagnonForever, v
BagnonTooltips, v
BankStack, vv23
BattlePetTabs, v1.0.7
Factionizer, v5.0.0.01
MinimalArchaeology, v4.0.3a (01.09.11)
PetBattleQualityGlow, v1.0.2
BlizRuntimeLib_enUS v5.0.4.50001 <us:3724>
(ck=116)

__________________
w.w.J.d. read the book and find out (J 3:16)

07-29-12, 06:40 PM

Vlad

A Molten Giant

Forum posts: 793

File comments: 337

Uploads: 31

Re: error opening pet window

Originally Posted by A_Nolan

error i found i have the 7/28/12 version 1.0.7
activated when i opened the pet window

I uploaded 1.0.8 -this happened because the pet abilities did not get saved properly, for some reason C_PetJournal.GetPetLoadOutInfo(index) a 0 so the pet wasn't properly stored (or there is no pet) -later the addon tried to look into that non-existant pets spells but since it didn't exist it errors like this. I think I fixed it by adding a simple if-check, try now and report back if it happened again.

10-06-12, 05:25 PM
Azbandar A Kobold Labourer Forum posts: 0 File comments: 2 Uploads: 0	Error without an error It seems to me that everytime I log out, my "saved" teams are wiped. If I never want to log out or switch characters, this is an awesome add-on. Let me know what you may need from me for more info and I'll give you what I can.

10-06-12, 05:44 PM

Vlad

A Molten Giant

Forum posts: 793

File comments: 337

Uploads: 31

Re: Error without an error

Originally Posted by Azbandar

It seems to me that everytime I log out, my "saved" teams are wiped. If I never want to log out or switch characters, this is an awesome add-on. Let me know what you may need from me for more info and I'll give you what I can.

This is with 1.1.0? I am working to fix this issue you see. Don't be surprised if I ask you how it the updates go as long this issue exists, hehe.

__________________
Profile: Curse | Wowhead

Last edited by Vlad : 10-06-12 at 05:58 PM.

12-12-12, 06:28 AM

mancini

A Kobold Labourer

Forum posts: 0

File comments: 2

Uploads: 0

fixing lost teams in 5.0 -> 5.1 transition

The problem is that the old pet id's were saved in decimal and they are now saved in hex by BattlePetTabs.

On OS X i just open BattlePetTabs.lua in a text editor like TextMate , select the three lines for the "team" entry for each team and filter trough the following unix command (works on linux too or windows with Cygwin):

awk -F, '{printf "\"0x0000000000%x\", %s\n",$1,$2}'

so the old entry like :

BattlePetTabsDB = {
{
["team"] = {
13435275, -- [1]
13212135, -- [2]
13320910, -- [3]

becomes:

BattlePetTabsDB = {
{
["team"] = {
"0x0000000000cd018b", -- [1]
"0x0000000000c999e7", -- [2]
"0x0000000000cb42ce", -- [3]

Doing this made my teams work just fine in 5.1.

If you have no choice but doing it manually you can use http://www.binaryhexconverter.com/decimal-to-hex-converter and just add 0x0000000000

Last edited by mancini : 12-12-12 at 06:34 AM.

12-12-12, 06:32 AM
Vlad A Molten Giant Forum posts: 793 File comments: 337 Uploads: 31	Hehe, yeah it's possible to save your pre 5.1 teams, if you got a backup of your lua file that is, just kind of easy to login after patch and notice they are gone, you then only have a .bat file (and that is gone too after you exit the game to update), but anyway, nice tutorial. __________________ Profile: Curse \| Wowhead

03-08-13, 12:43 PM
Barleduq Premium Member Forum posts: 135 File comments: 742 Uploads: 0	Very useful! I like this addon, and the ease with which I can keep track of which pets I'm using. I am, however, finding a need for more than 8 teams As I like to keep a team set for various levels, and various rarities (as I get more differnet ones) to easily swap when I'm wandering between zones quickly and spot a pet I don't have. (This is how I lost the nether faery dragon rare qq) Not a complaint, just a mention of a reason to have more than 8. Thank you!

03-09-13, 03:05 PM
Haleth This Space For Rent Forum posts: 1173 File comments: 1146 Uploads: 17	Since 5.2, when I select a different team, the pets in my loadout don't seem to update until I click the search box, or click the tab a second time. Very odd. Love the addon otherwise Last edited by Haleth : 03-09-13 at 03:11 PM.

03-11-13, 04:34 AM

Vlad

A Molten Giant

Forum posts: 793

File comments: 337

Uploads: 31

Originally Posted by Haleth

Since 5.2, when I select a different team, the pets in my loadout don't seem to update until I click the search box, or click the tab a second time.

They probably changed a bit on what functions are called when updating the information, so I gotta update my hooks to update at the right moments as well. Gonna take a look on my starter edition and see what happens.

Originally Posted by Barleduq

<snip> I am, however, finding a need for more than 8 teams

Yeah, it's on my list, and I wish to add this feature seamlessly without adding new ugly buttons or elements on screen, I was thinking perhaps adding a button purely for loadout switching (when you have more than 8 teams), you can think of it as "tabs" or something, just brainstorming here, but it would allow you to add more "tabs" or "groups" to a menu and using that you can add/remove more tabs/groups and each tab/group would contain up to 8 teams.

__________________
Profile: Curse | Wowhead

04-09-13, 04:36 AM
Tonyleila A Molten Giant Forum posts: 758 File comments: 2021 Uploads: 37	Nice addon! I noticed that Its switching pet talents much slower then PetBattle Teams - is there a CPU are Design reason for that? I'll come back as soon as you have added more tabs and maybe names for them I'll need them for the Daily Tamers, Low level pet hunting etc. __________________ Author of: LeilaUI and Aurora: Missing Textures __________________

Page 1 of 2

Report this File

Category Jump: